Skip to content

fix(pool): correct sequence of callback and token transfer in pool swap #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2025
Merged

fix(pool): correct sequence of callback and token transfer in pool swap #1008

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
666c0aa
fix(pool): correct sequence of callback and token transfer in pool swap
jinoosss Nov 26, 2025
a6f58b2
Merge branch 'main' into fix-pool-change-sequence-of-callback-and-tok…
jinoosss Nov 26, 2025
a8f0b53
Merge branch 'main' into fix-pool-change-sequence-of-callback-and-tok…
jinoosss Nov 28, 2025
f59ded1
Merge branch 'main' into fix-pool-change-sequence-of-callback-and-tok…
jinoosss Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contract/r/gnoswap/pool/v1/swap.gno
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,17 +238,17 @@ func (i *poolV1) Swap(
// receive token0 from swap callback
// send token1 to recipient (output)
if result.Amount1.IsNeg() {
i.safeSwapCallback(pool, token0Path, result.Amount0.Abs(), zeroForOne, swapCallback)

i.safeTransfer(pool, recipient, token1Path, result.Amount1.Abs(), false)

i.safeSwapCallback(pool, token0Path, result.Amount0.Abs(), zeroForOne, swapCallback)
}
} else {
// receive token1 from swap callback
// send token0 to recipient (output)
if result.Amount0.IsNeg() {
i.safeSwapCallback(pool, token1Path, result.Amount1.Abs(), zeroForOne, swapCallback)

i.safeTransfer(pool, recipient, token0Path, result.Amount0.Abs(), true)

i.safeSwapCallback(pool, token1Path, result.Amount1.Abs(), zeroForOne, swapCallback)
}
}

Expand Down
Loading