fix(bless): filter commented stdout lines in gas report parsing #1016
+567
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gas report parser was incorrectly matching commented lines like "# stdout 'GAS USED: 123'" because it only checked if the line contained the pattern, not if it started with it. Changes: - Add isValidStdoutLine function to check line starts with known prefix - Add STORAGE FEE to defaultStdoutPrefixes for consistency - Use isValidStdoutLine in parseGasOutput to filter commented lines
notJoon
reviewed
Nov 28, 2025
jinoosss
approved these changes
Nov 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix gas report parser incorrectly matching commented stdout lines.
Problem
The gas report parser was matching lines like
# stdout 'GAS USED: 123'because it only checked if the line contained the pattern, not if it started with it.Changes
isValidStdoutLinefunction to validate lines start with known prefixesSTORAGE FEE:todefaultStdoutPrefixesfor consistencyparseGasOutputto filter commented lines