Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1005 test makefiles to execute most of function #205

Merged
merged 7 commits into from
Apr 9, 2024
Merged

GSW-1005 test makefiles to execute most of function #205

merged 7 commits into from
Apr 9, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Apr 9, 2024

New

  1. makefile testing covers most of function

Change

  1. api json field names are being changed due to rdb refactor

ETC

draft for now, expecting bit of makefile test changes

@r3v4s r3v4s requested review from notJoon and mconcat April 9, 2024 01:06
@r3v4s r3v4s self-assigned this Apr 9, 2024
@r3v4s r3v4s marked this pull request as ready for review April 9, 2024 07:56
@notJoon notJoon merged commit a1ab898 into main Apr 9, 2024
1 check passed
@notJoon notJoon deleted the GSW-1005-test-makefiles-to-execute-most-of-function branch April 9, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@mconcat mconcat Awaiting requested review from mconcat

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v4s @notJoon