GSW-1839 Refactor/position contract utils #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- integrated helper with nft helper - add test helper code - add test code for helper - change file filename
- add assert functions - refactor original util functions
onlyhyde
changed the title
r3v4s
reviewed
Dec 11, 2024
r3v4s
reviewed
Dec 11, 2024
|
Adding wait-other-pr label ( seems like #432 needs to be merge first ) |
|
r3v4s
approved these changes
Dec 16, 2024
notJoon
approved these changes
Dec 16, 2024
onlyhyde
added a commit
that referenced
this pull request
Dec 18, 2024
* GSW-1839 refactor: integrated helper and test code - integrated helper with nft helper - add test helper code - add test code for helper - change file filename * GSW-1839 refactor: utils - add assert functions - refactor original util functions * Update position/utils_test.gno * test: Update to use the correct test values --------- Co-authored-by: Blake <[email protected]>
onlyhyde
added a commit
that referenced
this pull request
Jan 15, 2025
* refactor, test: calculateCollectReward * helper test * change getTokenPairBalanceFromPosition params * update doc * change emit param name * remove function prefix from panic * pool tier reward cache, pool reward cache, halving, warmup * chore: remove `Pool` prefix from pool's receiver getter (#423) * GSW-1838 test: swap_math unitest * test: define test helper function * test: remove unnecessary initialization * refactor: Use Clone data in function calls to protect original data * GSW-1838 test: sqrt_price_math unitest (#425) * refactor: sqrt_price_math - added testcase * refactor: add test code and comments * refactor: Overflow check for type conversion to int256 in delta amount calculation * refactor: dry swap (#421) * remove duplicate functions * GSW-1838 refactor: Using the new constructor to protect raw data in sqrtRatio calculations * GSW-1838 refactor: need to lock pool.slot0 to prevent re-entry * refactor: Using clone data to protect original data * refactor: remove unused import * fix: sqrtRatio calculation default value issue * refactor: swap and swap math * refactor: computeSwapStep - edge case test (amount : zero and over liquidity) - EXACT IN / EXACT OUT Case * refactor: Separate pool transfer-related test code * refactor: Rename a receiver function param and liquidity math bug fix - Fix absolute value before checking if delta value is negative to fix handling error issue if negative. - Rename the param in the receiver function from pool to p. * refactor: Changed large numbers to const for readability & removed some comments * refactor: Remove unnecessary function usage * refactor: Fix error messages to make their meaning clear * GSW-1839 refactor: integrated helper and test code (#432) * GSW-1839 Refactor/position contract utils (#433) * GSW-1839 refactor: integrated helper and test code - integrated helper with nft helper - add test helper code - add test code for helper - change file filename * GSW-1839 refactor: utils - add assert functions - refactor original util functions * Update position/utils_test.gno * test: Update to use the correct test values * GSW-1968 feat: check emission is caller or not (#435) * feat: add check logic for caller is emission or not * fix: remove deprecated require from gno.mod * Refactor/pool total (#442) * refactor: pool mint * refactor: name change transferFromAndVerify to safeTransferFrom * refactor: support checkTick when position modify * refactor: tick and position update * refactor: pool mint * refactor: collect and burn * refactor: collectProtocol * refactor: setFeeProtocol * refactor: createPool * refactor: Modify code based on code review comments * fix u256 error * rm: reward_internal_emission, reward_manager * rm: staker_type * rm: unnecessary test (staker_test) * rm: reward_recipient_store * rm: function prefix from panic messages * rm: tier_ratio, warm_up * rm: external_incentive_calculator * chore: change file name _GET_no_receiver -> getter * test: GetPoolStakedLiquidityUpdates * test, fix: api_calculation * modify external reward to be indexed by incentive id * test: more helpers * chore: exclude unittests * add per warmup retrieval * add warmup test * feat: getPrintInfo() * fix: gnoVM panics * fix: internal 01 test * fix: divide by zero * refactor: use grc20reg --------- Co-authored-by: Lee ByeongJun <[email protected]> Co-authored-by: Blake <[email protected]> Co-authored-by: n3wbie <[email protected]> Co-authored-by: 0xTopaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.