refactor(staker): staker

[notJoon]

Description

• Remove unused internal functions and imports
• Moved external incentive related functions from the staker file to a separate staker_external_incentive file
• Extract condition check as functions
• Change the parameters of the getTokenPairBalanceFromPosition function
  • The pool path is already obtained before this function is called with pn.PositionGetPositionPoolKey(tokenId) method, it is unnecessary to process it internally.

- func getTokenPairBalanceFromPosition(tokenId uint64) (string, string) {
+ func getTokenPairBalanceFromPosition(poolPath string, tokenId uint64) (string, string) {
- 	poolKey := pn.PositionGetPositionPoolKey(tokenId)
        // ...
}

Newly Added Test Files

• manage_pool_tiers
• reward_internal_emission
• reward_manager
• reward_recipient_store
• staker

Test Result

[r3v4s]

• do not inline get -> data check -> if nil panic -> if not nil type assertion for avl data
  • make it as separate function
• for testcase screenshot, run it from gnoswap's repo(with current br branch), not from gno

[notJoon]

* for testcase screenshot, run it from gnoswap's repo(with current br branch), not from gno

I don't think this will be a problem, since I just moved the entire main branch over to the gno side.

[r3v4s]

should be avl

[notJoon]

calc_pool_position_XXX prefix series files will be removed. don't need to change

[r3v4s]

no need err codes?

[notJoon]

The applyStake already returns errNoPermission in the transferDeposit function, so it does not have to handle it again.

// applyStake performs the actual staking operation by updating contract state.
func applyStake(s *stakeResult) error {
	deposits.Set(s.tokenId, s.deposit)

	if s.owner == s.caller {
		if err := transferDeposit(s.tokenId, s.owner, s.caller, consts.STAKER_ADDR); err != nil { // <-
			return err
		}
	}

	pn.SetPositionOperator(s.tokenId, s.caller)
	positionsInternalWarmUpAmount[s.tokenId] = warmUpAmount{}

	return nil
}

func transferDeposit(tokenId uint64, owner, caller, to std.Address) error {
	if caller == to {
		return ufmt.Errorf(
			"%v: only owner(%s) can transfer tokenId(%d), called from %s",
			errNoPermission, owner, tokenId, caller,
		) // <-
	}

	// transfer NFT ownership
	gnft.TransferFrom(a2u(owner), a2u(to), tid(tokenId))

	return nil
}

[r3v4s]

Separate getter(and setter) will be much better for nested avl datas.

[notJoon]

same as here: #437 (comment)

that global variable will be removed

[r3v4s]

liquidity is already huge number (that's why we use uint256 for it).
adding u256 + u256 does need overflow check.

[notJoon]

9a1d977

[sonarqubecloud]

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
5.7% Duplication on New Code

See analysis details on SonarQube Cloud

[notJoon]

branch has merged with PR #438