Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1968 refactor: integration common and position contract #447

Merged
merged 5 commits into from
Dec 23, 2024
Merged

GSW-1968 refactor: integration common and position contract #447

merged 5 commits into from
Dec 23, 2024

Conversation

onlyhyde
Copy link
Member

@onlyhyde onlyhyde commented Dec 21, 2024 •
edited by notJoon
Loading

  • Math function-focused modifications

Close: #445

@onlyhyde
GSW-1968 refactor: common contract
71a0c2d 
- Math function-focused modifications
@onlyhyde onlyhyde requested review from notJoon and r3v4s December 21, 2024 13:35
@onlyhyde onlyhyde marked this pull request as draft December 21, 2024 13:36
@onlyhyde onlyhyde changed the title GSW-1968 refactor: common contract GSW-1968 refactor: integration common and position contract Dec 21, 2024
r3v4s
r3v4s previously approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@onlyhyde onlyhyde marked this pull request as ready for review December 23, 2024 09:28
@r3v4s r3v4s self-requested a review December 23, 2024 09:33
notJoon
notJoon approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

r3v4s
r3v4s approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice 💯

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarQube Cloud

@onlyhyde onlyhyde merged commit 0eb82fa into main Dec 23, 2024
1 of 2 checks passed
@onlyhyde onlyhyde deleted the refactor/integration-common-position branch December 23, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@r3v4s r3v4s r3v4s approved these changes

Assignees

@onlyhyde onlyhyde

Labels
common integration position refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onlyhyde @notJoon @r3v4s