Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deploy contract on latest gnoland #457

Closed
wants to merge 7 commits into from
Closed

fix: deploy contract on latest gnoland #457

wants to merge 7 commits into from

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Jan 6, 2025

test with

  1. gnoswap's main brach (last commit 2aff909)
  2. gnoland's master branch (last commit gnolang/gno@beb48e7)

FIXED

  1. const to var when initializing with value
  2. unused value and imports
  3. xgns to latest spec
  4. interface type assertion (not conversion)
  5. bump gas-fee

Successful Deploy

every contract except for governance(gov/governance, gov/staker) and launchpad.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@r3v4s r3v4s marked this pull request as ready for review January 6, 2025 07:33
@r3v4s r3v4s requested review from onlyhyde, notJoon and mconcat January 6, 2025 07:33
@r3v4s r3v4s self-assigned this Jan 18, 2025
@dongwon8247
Copy link
Member

@r3v4s can you try deploying it one more time and resolve the conflict? then good to go.

@r3v4s
Copy link
Member Author

r3v4s commented Jan 20, 2025

closing due to repo structure change.

@r3v4s r3v4s closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@onlyhyde onlyhyde Awaiting requested review from onlyhyde

@mconcat mconcat Awaiting requested review from mconcat

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @dongwon8247 @notJoon