-
Notifications
You must be signed in to change notification settings - Fork 7
fix: *.Int64() -> safeConvertToInt64()
#812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dongwon8247
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check these additional points?
- POOL
- position.gno:122,127 - u256.MulDiv(...) for fee calculations (fee overflow)
- POSITION (String parsing issues)
- mint.gno:261,270 - mustParseInt64(amount0Desired)
- Large amounts fail to parse
- X96/X128 Operations Needing Protection
All these MulDiv operations need overflow checks:
- Pool fee growth: swap.gno:434
- Position fees: position.gno:122,127
- Liquidity calculations: Multiple files
- Reward calculations: reward_manager.gno:119
@dongwon8247 For the |
|



Description
Use safe type conversion