fix(gov/staker): removeStake not persisting updated reward state

[notJoon]

Descrption

removeStake updated/created an EmissionRewardState but did not write it back into rewardStates (AVL tree). For new addresses this meant the state was never persisted; for existing ones it could rely on pointer aliasing by accident.

Changes

Persist the updated state by calling:

e.rewardStates.Set(address, rewardState)

at the end of removeStake.

Also, changed the file name which was a typo.

Without persistence, per-address stake and reward debt can become out of sync with totalStakedAmount, leading to incorrect future rewards/claims.

Tests

Added regression tests:

• TestEmissionRewardManager_removeStake_persistsStateForNewAddress
• TestEmissionRewardManager_removeStake_updatesPersistedState

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud