Suspend the breakpoint if file is not found

go-delve · Jan 11, 2025 · 61ddeb0 · 61ddeb0
1 parent c4ab92e
commit 61ddeb0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/pkg/proc/bininfo.go b/pkg/proc/bininfo.go
@@ -930,6 +930,10 @@ func (err *ErrCouldNotFindLine) Error() string {
 	return fmt.Sprintf("could not find file %s", err.filename)
 }
 
+func (err *ErrCouldNotFindLine) IsFileFound() bool {
+	return err.fileFound
+}
+
 // AllPCsForFileLines returns a map providing all PC addresses for filename and each line in linenos
 func (bi *BinaryInfo) AllPCsForFileLines(filename string, linenos []int) map[int][]uint64 {
 	r := make(map[int][]uint64)

diff --git a/service/dap/server.go b/service/dap/server.go
@@ -1510,6 +1510,9 @@ func (s *Session) setBreakpoints(prefix string, totalBps int, metadataFunc func(
 				if err == nil {
 					// Create new breakpoints.
 					got, err = s.debugger.CreateBreakpoint(bp, "", nil, false)
+					if createBpError, isCouldNotFindLine := err.(*proc.ErrCouldNotFindLine); isCouldNotFindLine && !createBpError.IsFileFound() {
+						got, err = s.debugger.CreateBreakpoint(bp, "", nil, true)
+					}
 				}
 			}
 		}