proc,service: change FindLocation to work with multiple targets #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gotip failures are due to #54411 |
aarzilli
force-pushed
the
childdebug0
branch
2 times, most recently
from
ac08b7f to
21f544c
Compare
|
Sorry for the delay, will review more fully tomorrow morning my time. |
Changes FindLocation to support multiple targets and adds an AddrPid member to api.Breakpoint so that clients can set breakpoints by address when multiple targets are connected (but at them moment this field is ignored). Updates go-delve#1653 Updates go-delve#2551
aarzilli
force-pushed
the
childdebug0
branch
from
21f544c to
057918a
Compare
|
No problem. |
|
Sorry for taking forever to review, even after the above comment. Caught a bug last week that put me down for a few days. |
|
It's ok, I've been trying to get a review for this for 4 months: https://reviews.llvm.org/D128504 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes FindLocation to support multiple targets and adds an AddrPid
member to api.Breakpoint so that clients can set breakpoints by address
when multiple targets are connected (but at them moment this field is
ignored).
Updates #1653
Updates #2551