-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Get commits of a pull request #10918 #12118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
AndrewBezold
wants to merge
11
commits into
go-gitea:master
from
AndrewBezold:Get-commits-of-a-PullRequest-#10918
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d1bd7be
Add Get PR Commits API endpoint
e8ce202
Fix api call
AndrewBezold af0263a
Remove unused code
AndrewBezold 089f4b6
Add repo for PR testing
453f259
Add test PRs to fixtures
AndrewBezold d663e0e
Fix PR units
AndrewBezold d690b0a
Fix pull commits if merged
AndrewBezold 7abb941
Add tests for pr commits
AndrewBezold 4a08103
Update swagger
AndrewBezold 7e0765e
Remove headRepo load
be323a3
Update number of repos for user2
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// Copyright 2020 The Gitea Authors. All rights reserved. | ||
// Use of this source code is governed by a MIT-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package integrations | ||
|
||
import ( | ||
"net/http" | ||
"testing" | ||
|
||
"code.gitea.io/gitea/models" | ||
api "code.gitea.io/gitea/modules/structs" | ||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestAPIPullCommits(t *testing.T) { | ||
defer prepareTestEnv(t)() | ||
pullIssue := models.AssertExistsAndLoadBean(t, &models.PullRequest{ID: 6}).(*models.PullRequest) | ||
assert.NoError(t, pullIssue.LoadIssue()) | ||
repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: pullIssue.HeadRepoID}).(*models.Repository) | ||
|
||
// test ListPullReviews | ||
session := loginUser(t, "user2") | ||
req := NewRequestf(t, http.MethodGet, "/api/v1/repos/%s/%s/pulls/%d/commits", repo.OwnerName, repo.Name, pullIssue.Index) | ||
resp := session.MakeRequest(t, req, http.StatusOK) | ||
|
||
var commits []*api.Commit | ||
DecodeJSON(t, resp, &commits) | ||
if !assert.Len(t, commits, 3) { | ||
return | ||
} | ||
assert.Equal(t, "c711aebdd140cebd540469c0de87960457a0ab81", commits[0].SHA) | ||
assert.Equal(t, "f6211fabb4e7f31f76b64dda1aa8545ff7eb2e78", commits[1].SHA) | ||
assert.Equal(t, "443bb80f40ada270ea0d8b9df4ce7f1173a5748a", commits[2].SHA) | ||
} | ||
|
||
func TestAPIMergedPullCommits(t *testing.T) { | ||
defer prepareTestEnv(t)() | ||
pullIssue := models.AssertExistsAndLoadBean(t, &models.PullRequest{ID: 7}).(*models.PullRequest) | ||
assert.NoError(t, pullIssue.LoadIssue()) | ||
repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: pullIssue.HeadRepoID}).(*models.Repository) | ||
|
||
// test ListPullReviews | ||
session := loginUser(t, "user2") | ||
req := NewRequestf(t, http.MethodGet, "/api/v1/repos/%s/%s/pulls/%d/commits", repo.OwnerName, repo.Name, pullIssue.Index) | ||
resp := session.MakeRequest(t, req, http.StatusOK) | ||
|
||
var commits []*api.Commit | ||
DecodeJSON(t, resp, &commits) | ||
if !assert.Len(t, commits, 2) { | ||
return | ||
} | ||
assert.Equal(t, "e3dfaeb234e2a4570875ea3be7cedaebf350d703", commits[0].SHA) | ||
assert.Equal(t, "a20333be2715060c61c8d0268c4f622bde1ae4ac", commits[1].SHA) | ||
} | ||
|
||
func TestAPIClosedPullCommits(t *testing.T) { | ||
defer prepareTestEnv(t)() | ||
pullIssue := models.AssertExistsAndLoadBean(t, &models.PullRequest{ID: 8}).(*models.PullRequest) | ||
assert.NoError(t, pullIssue.LoadIssue()) | ||
repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: pullIssue.HeadRepoID}).(*models.Repository) | ||
|
||
// test ListPullReviews | ||
session := loginUser(t, "user2") | ||
req := NewRequestf(t, http.MethodGet, "/api/v1/repos/%s/%s/pulls/%d/commits", repo.OwnerName, repo.Name, pullIssue.Index) | ||
resp := session.MakeRequest(t, req, http.StatusOK) | ||
|
||
var commits []*api.Commit | ||
DecodeJSON(t, resp, &commits) | ||
if !assert.Len(t, commits, 2) { | ||
return | ||
} | ||
assert.Equal(t, "f611a4c2dc1894ebbe5e8b558b4055169506048b", commits[0].SHA) | ||
assert.Equal(t, "e1adcf142a07305ebf40590a41b1a279486759db", commits[1].SHA) | ||
} |
1 change: 1 addition & 0 deletions
1
integrations/gitea-repositories-meta/user2/pr_repo.git/FETCH_HEAD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
71ef50ba32849b9b7b4d8c98dd98f5a68134c62f branch 'master' of C:\other\gitea-repositories\user2\pr_repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ref: refs/heads/master |
6 changes: 6 additions & 0 deletions
6
integrations/gitea-repositories-meta/user2/pr_repo.git/config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[core] | ||
repositoryformatversion = 0 | ||
filemode = false | ||
bare = true | ||
symlinks = false | ||
ignorecase = true |
1 change: 1 addition & 0 deletions
1
integrations/gitea-repositories-meta/user2/pr_repo.git/description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Unnamed repository; edit this file 'description' to name the repository. |
15 changes: 15 additions & 0 deletions
15
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/applypatch-msg.sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#!/bin/sh | ||
# | ||
# An example hook script to check the commit log message taken by | ||
# applypatch from an e-mail message. | ||
# | ||
# The hook should exit with non-zero status after issuing an | ||
# appropriate message if it wants to stop the commit. The hook is | ||
# allowed to edit the commit message file. | ||
# | ||
# To enable this hook, rename this file to "applypatch-msg". | ||
|
||
. git-sh-setup | ||
commitmsg="$(git rev-parse --git-path hooks/commit-msg)" | ||
test -x "$commitmsg" && exec "$commitmsg" ${1+"$@"} | ||
: |
24 changes: 24 additions & 0 deletions
24
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/commit-msg.sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#!/bin/sh | ||
# | ||
# An example hook script to check the commit log message. | ||
# Called by "git commit" with one argument, the name of the file | ||
# that has the commit message. The hook should exit with non-zero | ||
# status after issuing an appropriate message if it wants to stop the | ||
# commit. The hook is allowed to edit the commit message file. | ||
# | ||
# To enable this hook, rename this file to "commit-msg". | ||
|
||
# Uncomment the below to add a Signed-off-by line to the message. | ||
# Doing this in a hook is a bad idea in general, but the prepare-commit-msg | ||
# hook is more suited to it. | ||
# | ||
# SOB=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p') | ||
# grep -qs "^$SOB" "$1" || echo "$SOB" >> "$1" | ||
|
||
# This example catches duplicate Signed-off-by lines. | ||
|
||
test "" = "$(grep '^Signed-off-by: ' "$1" | | ||
sort | uniq -c | sed -e '/^[ ]*1[ ]/d')" || { | ||
echo >&2 Duplicate Signed-off-by lines. | ||
exit 1 | ||
} |
114 changes: 114 additions & 0 deletions
114
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/fsmonitor-watchman.sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
#!/usr/bin/perl | ||
|
||
use strict; | ||
use warnings; | ||
use IPC::Open2; | ||
|
||
# An example hook script to integrate Watchman | ||
# (https://facebook.github.io/watchman/) with git to speed up detecting | ||
# new and modified files. | ||
# | ||
# The hook is passed a version (currently 1) and a time in nanoseconds | ||
# formatted as a string and outputs to stdout all files that have been | ||
# modified since the given time. Paths must be relative to the root of | ||
# the working tree and separated by a single NUL. | ||
# | ||
# To enable this hook, rename this file to "query-watchman" and set | ||
# 'git config core.fsmonitor .git/hooks/query-watchman' | ||
# | ||
my ($version, $time) = @ARGV; | ||
|
||
# Check the hook interface version | ||
|
||
if ($version == 1) { | ||
# convert nanoseconds to seconds | ||
$time = int $time / 1000000000; | ||
} else { | ||
die "Unsupported query-fsmonitor hook version '$version'.\n" . | ||
"Falling back to scanning...\n"; | ||
} | ||
|
||
my $git_work_tree; | ||
if ($^O =~ 'msys' || $^O =~ 'cygwin') { | ||
$git_work_tree = Win32::GetCwd(); | ||
$git_work_tree =~ tr/\\/\//; | ||
} else { | ||
require Cwd; | ||
$git_work_tree = Cwd::cwd(); | ||
} | ||
|
||
my $retry = 1; | ||
|
||
launch_watchman(); | ||
|
||
sub launch_watchman { | ||
|
||
my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j --no-pretty') | ||
or die "open2() failed: $!\n" . | ||
"Falling back to scanning...\n"; | ||
|
||
# In the query expression below we're asking for names of files that | ||
# changed since $time but were not transient (ie created after | ||
# $time but no longer exist). | ||
# | ||
# To accomplish this, we're using the "since" generator to use the | ||
# recency index to select candidate nodes and "fields" to limit the | ||
# output to file names only. Then we're using the "expression" term to | ||
# further constrain the results. | ||
# | ||
# The category of transient files that we want to ignore will have a | ||
# creation clock (cclock) newer than $time_t value and will also not | ||
# currently exist. | ||
|
||
my $query = <<" END"; | ||
["query", "$git_work_tree", { | ||
"since": $time, | ||
"fields": ["name"], | ||
"expression": ["not", ["allof", ["since", $time, "cclock"], ["not", "exists"]]] | ||
}] | ||
END | ||
|
||
print CHLD_IN $query; | ||
close CHLD_IN; | ||
my $response = do {local $/; <CHLD_OUT>}; | ||
|
||
die "Watchman: command returned no output.\n" . | ||
"Falling back to scanning...\n" if $response eq ""; | ||
die "Watchman: command returned invalid output: $response\n" . | ||
"Falling back to scanning...\n" unless $response =~ /^\{/; | ||
|
||
my $json_pkg; | ||
eval { | ||
require JSON::XS; | ||
$json_pkg = "JSON::XS"; | ||
1; | ||
} or do { | ||
require JSON::PP; | ||
$json_pkg = "JSON::PP"; | ||
}; | ||
|
||
my $o = $json_pkg->new->utf8->decode($response); | ||
|
||
if ($retry > 0 and $o->{error} and $o->{error} =~ m/unable to resolve root .* directory (.*) is not watched/) { | ||
print STDERR "Adding '$git_work_tree' to watchman's watch list.\n"; | ||
$retry--; | ||
qx/watchman watch "$git_work_tree"/; | ||
die "Failed to make watchman watch '$git_work_tree'.\n" . | ||
"Falling back to scanning...\n" if $? != 0; | ||
|
||
# Watchman will always return all files on the first query so | ||
# return the fast "everything is dirty" flag to git and do the | ||
# Watchman query just to get it over with now so we won't pay | ||
# the cost in git to look up each individual file. | ||
print "/\0"; | ||
eval { launch_watchman() }; | ||
exit 0; | ||
} | ||
|
||
die "Watchman: $o->{error}.\n" . | ||
"Falling back to scanning...\n" if $o->{error}; | ||
|
||
binmode STDOUT, ":utf8"; | ||
local $, = "\0"; | ||
print @{$o->{files}}; | ||
} |
15 changes: 15 additions & 0 deletions
15
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/post-receive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#!/usr/bin/env bash | ||
data=$(cat) | ||
exitcodes="" | ||
hookname=$(basename $0) | ||
GIT_DIR=${GIT_DIR:-$(dirname $0)} | ||
|
||
for hook in ${GIT_DIR}/hooks/${hookname}.d/*; do | ||
test -x "${hook}" && test -f "${hook}" || continue | ||
echo "${data}" | "${hook}" | ||
exitcodes="${exitcodes} $?" | ||
done | ||
|
||
for i in ${exitcodes}; do | ||
[ ${i} -eq 0 ] || exit ${i} | ||
done |
2 changes: 2 additions & 0 deletions
2
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/post-receive.d/gitea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
#!/usr/bin/env bash | ||
"C:/other/gitea/gitea.exe" hook --config='C:/other/gitea/custom/conf/app.ini' post-receive |
8 changes: 8 additions & 0 deletions
8
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/post-update.sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#!/bin/sh | ||
# | ||
# An example hook script to prepare a packed repository for use over | ||
# dumb transports. | ||
# | ||
# To enable this hook, rename this file to "post-update". | ||
|
||
exec git update-server-info |
14 changes: 14 additions & 0 deletions
14
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/pre-applypatch.sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
#!/bin/sh | ||
# | ||
# An example hook script to verify what is about to be committed | ||
# by applypatch from an e-mail message. | ||
# | ||
# The hook should exit with non-zero status after issuing an | ||
# appropriate message if it wants to stop the commit. | ||
# | ||
# To enable this hook, rename this file to "pre-applypatch". | ||
|
||
. git-sh-setup | ||
precommit="$(git rev-parse --git-path hooks/pre-commit)" | ||
test -x "$precommit" && exec "$precommit" ${1+"$@"} | ||
: |
49 changes: 49 additions & 0 deletions
49
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/pre-commit.sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
#!/bin/sh | ||
# | ||
# An example hook script to verify what is about to be committed. | ||
# Called by "git commit" with no arguments. The hook should | ||
# exit with non-zero status after issuing an appropriate message if | ||
# it wants to stop the commit. | ||
# | ||
# To enable this hook, rename this file to "pre-commit". | ||
|
||
if git rev-parse --verify HEAD >/dev/null 2>&1 | ||
then | ||
against=HEAD | ||
else | ||
# Initial commit: diff against an empty tree object | ||
against=$(git hash-object -t tree /dev/null) | ||
fi | ||
|
||
# If you want to allow non-ASCII filenames set this variable to true. | ||
allownonascii=$(git config --bool hooks.allownonascii) | ||
|
||
# Redirect output to stderr. | ||
exec 1>&2 | ||
|
||
# Cross platform projects tend to avoid non-ASCII filenames; prevent | ||
# them from being added to the repository. We exploit the fact that the | ||
# printable range starts at the space character and ends with tilde. | ||
if [ "$allownonascii" != "true" ] && | ||
# Note that the use of brackets around a tr range is ok here, (it's | ||
# even required, for portability to Solaris 10's /usr/bin/tr), since | ||
# the square bracket bytes happen to fall in the designated range. | ||
test $(git diff --cached --name-only --diff-filter=A -z $against | | ||
LC_ALL=C tr -d '[ -~]\0' | wc -c) != 0 | ||
then | ||
cat <<\EOF | ||
Error: Attempt to add a non-ASCII file name. | ||
|
||
This can cause problems if you want to work with people on other platforms. | ||
|
||
To be portable it is advisable to rename the file. | ||
|
||
If you know what you are doing you can disable this check using: | ||
|
||
git config hooks.allownonascii true | ||
EOF | ||
exit 1 | ||
fi | ||
|
||
# If there are whitespace errors, print the offending file names and fail. | ||
exec git diff-index --check --cached $against -- |
53 changes: 53 additions & 0 deletions
53
integrations/gitea-repositories-meta/user2/pr_repo.git/hooks/pre-push.sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
#!/bin/sh | ||
|
||
# An example hook script to verify what is about to be pushed. Called by "git | ||
# push" after it has checked the remote status, but before anything has been | ||
# pushed. If this script exits with a non-zero status nothing will be pushed. | ||
# | ||
# This hook is called with the following parameters: | ||
# | ||
# $1 -- Name of the remote to which the push is being done | ||
# $2 -- URL to which the push is being done | ||
# | ||
# If pushing without using a named remote those arguments will be equal. | ||
# | ||
# Information about the commits which are being pushed is supplied as lines to | ||
# the standard input in the form: | ||
# | ||
# <local ref> <local sha1> <remote ref> <remote sha1> | ||
# | ||
# This sample shows how to prevent push of commits where the log message starts | ||
# with "WIP" (work in progress). | ||
|
||
remote="$1" | ||
url="$2" | ||
|
||
z40=0000000000000000000000000000000000000000 | ||
|
||
while read local_ref local_sha remote_ref remote_sha | ||
do | ||
if [ "$local_sha" = $z40 ] | ||
then | ||
# Handle delete | ||
: | ||
else | ||
if [ "$remote_sha" = $z40 ] | ||
then | ||
# New branch, examine all commits | ||
range="$local_sha" | ||
else | ||
# Update to existing branch, examine new commits | ||
range="$remote_sha..$local_sha" | ||
fi | ||
|
||
# Check for WIP commit | ||
commit=`git rev-list -n 1 --grep '^WIP' "$range"` | ||
if [ -n "$commit" ] | ||
then | ||
echo >&2 "Found WIP commit in $local_ref, not pushing" | ||
exit 1 | ||
fi | ||
fi | ||
done | ||
|
||
exit 0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?