-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix redundant dividers on search for labels #25303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At first glance, it's quite hacky. I guess it's not the right way. |
In the video, the extra dividers are still seen while typing, so yes I think the solution can't be right. |
Actually, Fomantic UI does very well for "hiding dividers". We only needs 2 lines:
|
That's great, I will close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
topic/ui
Change the appearance of the Gitea UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels search dropdowns have redundant dividers when searching for labels
This PR adds
data-divider-index
anddata-divider-group
to dynamically toggle the visibility of dividers depending on filtered results. And slightly changed the logic for adding the divider if there are bothLabels
andOrgLabels
exist.After:
Untitled.mov
Locations of the dropdowns:
On sidebar of issue/pr, and on repo issue/pr list