Fix: Hide divider when labels are hidden

[neel1996]

Summary

Empty dividers are shown with no enclosed labels when the archived labels are hidden from list

Before fix

The dividers will show on the list even if the enclosed labels are hidden

After the fix

The divider has been conditionally hidden when the label is not shown in the list

• With archived labels hidden

• With archived labels shown

Fixed #27466

[delvh]

This is only a partial fix as it will be buggy when you have a scope with an archived label and an active label, and the checkbox is not selected.
In that case, the divider will be missing even though it shouldn't.

[puni9869]

quickest solution As of now lets remove all the divider tags.

I am working on something similar,
Keeping all the checked or ticked label on to top in the label drop down list.

My fix will take lil more time, mean while we can fix it via this

@neel1996

[delvh]

lets remove all the divider tags.

Erm… This sounds even worse?

[puni9869]

lets remove all the divider tags.

Erm… This sounds even worse?

Quickfix
regression #27747

@neel1996 I have fix this problem in the above Pr, If you get time you can review.

[wxiaoguang]

It should have been fixed in 1.23?

[wxiaoguang]

Not fixed, and it is not an easy problem.

The problem is that tw-hidden doesn't work with the dropdown divider. It can't be fixed by template patches.

Frontend dropdown needs to "filter" the list. So it also needs to handle such case:

item1
divider
item2 (not matched the input and will be hidden by frontend)
divider (this will also be hidden)
item3

Actually the dropdown could already handles such case, but it is unable to mix these 2 different usages if item2 is hidden by other methods but not by the filter.

[wxiaoguang]

It could be fixed like this: Fix duplicate dropdown dividers #32760