-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix: Hide divider when labels are hidden #27747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c26992e
da8ba4a
9d18875
8d7231e
8aea6c3
d3dec1d
bcb0ff9
a5c573f
72417e1
008d5f1
b50980f
5aed712
3282c9b
7159ef7
2e1f53d
845c373
e669ae0
f4c6f13
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -744,5 +744,7 @@ export function initArchivedLabelHandler() { | |
if (!document.querySelector('.archived-label-hint')) return; | ||
for (const label of document.querySelectorAll('[data-is-archived]')) { | ||
toggleElem(label, label.classList.contains('checked')); | ||
// also toggle the divider | ||
toggleElem($(label).next('.exclusive-scope'), label.classList.contains('checked')); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See above There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will test it rigorously. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The usecase I imagine to be faulty is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same I was thinking, with org labels as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 4805034b-ceec-46cd-8631-fca2b25a2d38.mp4This is the current condition with org and repo labels with all possible usecase, |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.