-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Notes for Project-Board-Columns #29045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@gitZokki I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. 🍵 |
After a few more hours I have more questions
In the feature-request for the BoardNotes there are some things I think are not important to add
|
Maybe we can merge #30170 first. |
Whichever is ready first will be first and the other will suffer merge conflicts 😆. |
Does this PR contains the fix in #26561? |
Please resolve the conflicts, sorry the rename PR results in so many conflicts. |
"xorm.io/xorm" | ||
) | ||
|
||
type BoardNote struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Board
has been renamed to Column
, this should be ColumnNote
now.
To be honest, I would suggest new contributors to start from some small PRs, instead of proposing a large feature before having been familiar enough with the whole code base, I can see there are many hacky approaches ..... and mixed with other bug-fixes which have been implemented by other PRs. IMO this PR needs a deep clean up to continue .......... |
Functionality
Closes Project Board-Column-Titles are without ellipsis #29029Closes Edited Project-Column titles missing the number of issues #29031Fixes a bug that the wrong cursor was used on column-titleThis is my first time working with GO, so please be nice and I will try anything to help with this feature