Change commit page signature indication to icon only #30221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/templates
silverwind
commented
Apr 1, 2024
| {{if .Verification.Reason}} | ||
| {{$text = (ctx.Locale.Tr .Verification.Reason)}} | ||
| {{else}} | ||
| {{$text = (ctx.Locale.Tr "sig_failed")}} |
There was a problem hiding this comment.
Not sure if this condition can be reached. At least it wasn't necessary before, so maybe can remove.
|
silverwind
commented
Apr 1, 2024
|
Should be fixed with 5965d4a, no idea why it didn't error for me 😆 |
|
WIP because I need to double-check that the logic is same as previous, it's quite convoluted. |
|
"De-emphasize signed commits #31160" has done it. The only remaining thing is to "fine tune" some colors. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29641.
Commit page header is now always uncolored and the signature status is shown by a new icon:
