Set manual tabindexes on login page
#31689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
wxiaoguang
reviewed
Jul 24, 2024
silverwind
changed the title
tabindexes on login page
|
The only way I'll approve this PR as it is is if you document somewhere in that file exactly why we have this weird tab order. |
|
Yes, I thought about adding a comment so this does not break during refactoring. I don't think it's weird, it's more like "optimized for usability" and the position for the forgot link is ideal and follows what other login forms do as well. |
I meant for someone who looks over the code and hasn't seen this PR. |
techknowlogick
previously requested changes
Jul 25, 2024
GiteaBot
added
lgtm/blocked
KN4CK3R
approved these changes
Sep 18, 2024
lunny
approved these changes
Sep 18, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lafriks
approved these changes
Sep 20, 2024
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 21, 2024
* giteaofficial/main: Fix incorrect `/tokens` api (go-gitea#32085) Set manual `tabindex`es on login page (go-gitea#31689) Only use Host header from reverse proxy (go-gitea#32060) [skip ci] Updated translations via Crowdin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31686.
A more elborate manual tabindex numbering could be done, but I think it's not really worth the extra effort and such stuff could easily break during refactors.
Includes another small tweak to un-stretch the
<a>element so it's only as large as it needs to be and this change also made the margin unneeded.