Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of Typescript issues #31877

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

silverwind
Copy link
Member

Typescript error count is reduced from 633 to 540 with this. No runtime changes except in test code.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 19, 2024
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 23, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 28, 2024
@silverwind silverwind merged commit 7207d93 into go-gitea:main Aug 28, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 28, 2024
@silverwind silverwind deleted the types-3 branch August 28, 2024 16:32
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 29, 2024
* giteaofficial/main:
  Fix a number of Typescript issues (go-gitea#31877)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants