Only use Host header from reverse proxy #32060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
force-pushed
the
fox-host-header
branch
from
5257432 to
821f26a
Compare
lunny
approved these changes
Sep 17, 2024
GiteaBot
added
lgtm/need 1
yp05327
approved these changes
Sep 18, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wxiaoguang
force-pushed
the
fox-host-header
branch
from
c1ca8f4 to
fab2152
Compare
wxiaoguang
force-pushed
the
fox-host-header
branch
4 times, most recently
from
ac4319b to
cebffcf
Compare
wxiaoguang
force-pushed
the
fox-host-header
branch
from
cebffcf to
057f336
Compare
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 21, 2024
* giteaofficial/main: Fix incorrect `/tokens` api (go-gitea#32085) Set manual `tabindex`es on login page (go-gitea#31689) Only use Host header from reverse proxy (go-gitea#32060) [skip ci] Updated translations via Crowdin
lunny
added a commit
that referenced
this pull request
Sep 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-Forwarded-Host has many problems: non-standard, not well-defined (X-Forwarded-Port or not), conflicts with Host header, it already caused problems like #31907. So do not use X-Forwarded-Host, just use Host header directly.
Official document also only uses
Hostheader and never mentioned others.