Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CI,Flake and Snap to Node 22 #32487

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Bump CI,Flake and Snap to Node 22 #32487

merged 3 commits into from
Nov 13, 2024

Conversation

silverwind
Copy link
Member

Node 22 is LTS since 2024-10-29. Updated it everywhere.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 13, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2024
techknowlogick
techknowlogick approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Are you able to do a nix flake update as well, or if not then I could.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 13, 2024
@techknowlogick techknowlogick requested a review from 6543 November 13, 2024 17:42
@silverwind
Copy link
Member Author

I don't have nix installed and I'm not sure I want to install it (don't want it to take over my system), so if you can, please do.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 13, 2024
@techknowlogick
Copy link
Member

I don't have nix installed and I'm not sure I want to install it (don't want it to take over my system), so if you can, please do.

np, just pushed the patch :)

@techknowlogick techknowlogick enabled auto-merge (squash) November 13, 2024 21:09
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 13, 2024
@techknowlogick techknowlogick merged commit 9880c13 into go-gitea:main Nov 13, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 13, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 13, 2024
6543
6543 reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@silverwind silverwind deleted the node22 branch November 14, 2024 00:56
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6332a5e 
* giteaofficial/main:
  Refactor render system (go-gitea#32492)
  Fix nil panic if repo doesn't exist (go-gitea#32501)
  Bump CI,Flake and Snap to Node 22 (go-gitea#32487)
  Perf: add extra index to notification table (go-gitea#32395)
  Fix LFS route mock, realm, middleware names (go-gitea#32488)
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Nov 14, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 left review comments

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @techknowlogick @lunny @6543 @wxiaoguang @GiteaBot