Fix labels display

[stuzer05]

Fixes #32758

also fixes exclusive from repo and org grouping

search fixed using css

[wxiaoguang]

The divider between "repo" labels and "org" labels are added intentionally, if you hide it, people are not able to distinguish "reop/org" labels.

bug (repo)
bug (org)
...

[stuzer05]

The divider between "repo" labels and "org" labels are added intentionally, if you hide it, people are not able to distinguish "reop/org" labels.

bug (repo)
bug (org)
...

Is there a use case to have identical labels under org and repo? repo labls are more like "extension" of general, org labels

[stuzer05]

Besides, divider between repo and org labels doesn't hint which labels are org and repo owned. It only "breaks" the sorting/grouping

[wxiaoguang]

Besides the problem above, I do no think it could work. I have explained in the issue, the "filter" problem is one of the root problems.

[stuzer05]

Besides the problem above, I do no think it could work. I have explained in the issue, the "filter" problem is one of the root problems.

Maybe js dropdown on refresh and template fix could be combined. I understand, dropdown js fix is a "crutch" of a sort

[stuzer05]

Besides the problem above, I do no think it could work. I have explained in the issue, the "filter" problem is one of the root problems.

Maybe js dropdown on refresh and template fix could be combined. I understand, dropdown js fix is a "crutch" of a sort

This could be fixed by css

.filtered + .divider {
    display: none;
}

[stuzer05]

[wxiaoguang]

Besides the problem above, I do no think it could work. I have explained in the issue, the "filter" problem is one of the root problems.

Maybe js dropdown on refresh and template fix could be combined. I understand, dropdown js fix is a "crutch" of a sort

This could be fixed by css

.filtered + .divider {
    display: none;
}

It can't be right either.

<div>label a</div>
---- <div class="divider"></div>
<div data-scope="xxx">label b-1</div>
<div data-scope="xxx" class="filtered">label b-2</div>
---- <div class="divider"></div> here, you shouldn't hide it.
<div>label c</div>

[stuzer05]

It can't be right either.

<div>label a</div>
---- <div class="divider"></div>
<div data-scope="xxx">label b-1</div>
<div data-scope="xxx" class="filtered">label b-2</div>
---- <div class="divider"></div> here, you shouldn't hide it.
<div>label c</div>

Visually it works, can you share a screenshot?

[wxiaoguang]

Visually it works, can you share a screenshot?

Before "visual work", we should make it "theoretically right", right?

I have finished my " Fix duplicate dropdown dividers #32760 ", and added enough tests, I think it should work for all cases. The behavior is 100% controlled and we could always fine-tune it by what we need.

[stuzer05]

Visually it works, can you share a screenshot?

Before "visual work", we should make it "theoretically right", right?

I have finished my " Fix duplicate dropdown dividers #32760 ", and added enough tests, I think it should work for all cases. The behavior is 100% controlled and we could always fine-tune it by what we need.

Can we merge repo and org labels as well? I don't see any reason why we should separate them, because now:

1. repo and org labels aren't visually separated, only by position (not obvious)
2. should user really think about where labels are refined? - it's more an administrative work
3. grouping makes more sense and make find labels easy instead of confusing users

scope_a/1
scope_a/2
label_3
scope_a/3

looks "broken" in UX

[wxiaoguang]

Can we merge repo and org labels as well? I don't see any reason why we should separate them, because now:

I have no idea, I do not use these features, maybe you could open a proposal and invite the initial contributors to provide feedbacks.