Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In some lfs server implementations, they require the ref attribute. #32838

Merged
merged 7 commits into from
Dec 15, 2024
Merged

In some lfs server implementations, they require the ref attribute. #32838

merged 7 commits into from
Dec 15, 2024

Conversation

hiifong
Copy link
Member

@hiifong hiifong commented Dec 14, 2024 •
edited
Loading

Fix: #32611

In some lfs server implementations, they require the ref attribute. Note: Added in v2.4.

https://github.com/git-lfs/git-lfs/blob/a32a02b44bf8a511aa14f047627c49e1a7fd5021/docs/api/batch.md?plain=1#L37

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 14, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 14, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 14, 2024
@wxiaoguang
Copy link
Contributor

What if an object is not stored in "default branch"?

  • Before: objects in all branches should be downloaded
  • After: only objects in default branch could be downloaded?

@lunny lunny added the type/bug label Dec 14, 2024
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2024
@hiifong
Copy link
Member Author

hiifong commented Dec 14, 2024

What if an object is not stored in "default branch"?

  • Before: objects in all branches should be downloaded
  • After: only objects in default branch could be downloaded?

Updated

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2024
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 15, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) December 15, 2024 02:00
@wxiaoguang wxiaoguang merged commit 7616aeb into go-gitea:main Dec 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 15, 2024
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Dec 15, 2024
@hiifong hiifong deleted the fix/lfs-migration branch December 15, 2024 02:32
@hiifong hiifong mentioned this pull request Dec 15, 2024
Closed
@wxiaoguang wxiaoguang mentioned this pull request Jan 31, 2025
Closed
@wxiaoguang
Copy link
Contributor

We need to revert this, it causes more problems like "Unable to migrrate repos from Hugging Face #33453"

@lunny
Copy link
Member

lunny commented Jan 31, 2025

#32611 need to be reopen

@wxiaoguang
Copy link
Contributor

#32611 need to be reopen

I believe it is aliyun's problem, they should fix their LFS bug.

@wxiaoguang wxiaoguang mentioned this pull request Jan 31, 2025
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

mirror: LFS client version too old
5 participants
@hiifong @wxiaoguang @lunny @delvh @GiteaBot