Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more load functions to make sure the reference object loaded #32901

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Add more load functions to make sure the reference object loaded #32901

merged 3 commits into from
Dec 19, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 18, 2024

Fix #32897

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2024
@lunny lunny merged commit dc8f59b into go-gitea:main Dec 19, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 19, 2024
@lunny lunny deleted the lunny/fix_bug branch December 19, 2024 06:10
@lunny lunny added the backport/v1.23 This PR should be backported to Gitea 1.23 label Dec 19, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 19, 2024
@lunny @GiteaBot
Add more load functions to make sure the reference object loaded (go-…
2909873 
…gitea#32901)

Fix go-gitea#32897
@GiteaBot GiteaBot mentioned this pull request Dec 19, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 19, 2024
silverwind pushed a commit that referenced this pull request Dec 19, 2024
@GiteaBot @lunny
Add more load functions to make sure the reference object loaded (#32901
a4291fd 
) (#32912)

Backport #32901 by @lunny

Fix #32897

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Panic in createIssueComment()
5 participants
@lunny @Zettat123 @a1012112796 @delvh @GiteaBot