Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n.go - Language Picker #32933

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Conversation

aindriu80
Copy link
Contributor

@aindriu80 aindriu80 commented Dec 20, 2024

Updated i18n.go to enable Irish(Gaeilge) language selection, which is fully translated.

Updated i18n.go to enable Irish(Gaeilge) language selection, which is fully translated.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 20, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 20, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 20, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) December 20, 2024 18:52
@techknowlogick techknowlogick added backport/v1.22 This PR should be backported to Gitea 1.22 backport/v1.23 This PR should be backported to Gitea 1.23 labels Dec 20, 2024
@lunny
Copy link
Member

lunny commented Dec 20, 2024

I don't know whether we should backport because I don't know whether the translations have been backported to those versions. If we want to backport, it's also very difficult because the translations keys are changed.

@wxiaoguang wxiaoguang removed the backport/v1.22 This PR should be backported to Gitea 1.22 label Dec 21, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 21, 2024
@techknowlogick techknowlogick merged commit 23687a0 into go-gitea:main Dec 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 21, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 21, 2024
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 21, 2024
@aindriu80
Copy link
Contributor Author

@lunny thanks for the merge.

Regarding backporting - I know that if any of the language keys are changed on Crowdin they appear red for retranslating. They are 100% green at the moment, but I'm not sure if this is relevant to the issue.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 23, 2024
* giteaofficial/main: (62 commits)
  Fix repo avatar conflict (go-gitea#32958)
  [skip ci] Updated licenses and gitignores
  fix trailing comma not matched in the case of alphanumeric issue (go-gitea#32945)
  Add auto-expanding running actions step (go-gitea#30058)
  Fix go-gitea#32954 (go-gitea#32955)
  Use Alpine 3.21 for the docker images (go-gitea#32924)
  Refactor template & test related code (go-gitea#32938)
  Use primary as button color (go-gitea#32949)
  [skip ci] Updated translations via Crowdin
  Add action auto-scroll (go-gitea#30057)
  Fix locale (go-gitea#32937)
  Enable Typescript `strictFunctionTypes` (go-gitea#32911)
  Fix areYouSure confirm (go-gitea#32941)
  Update i18n.go - Language Picker (go-gitea#32933)
  Move some errors to their own sub packages (go-gitea#32880)
  Improve navbar: add "admin" tip, add "active" style (go-gitea#32927)
  Refactor db package and remove unnecessary `DumpTables` (go-gitea#32930)
  show warning on navigation if currently editing comment or title (go-gitea#32920)
  Refactor pprof labels and process desc (go-gitea#32909)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants