Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trailing comma not matched in the case of alphanumeric issue #32945

Merged
merged 3 commits into from
Dec 22, 2024
Merged

fix trailing comma not matched in the case of alphanumeric issue #32945

merged 3 commits into from
Dec 22, 2024

Conversation

katsusan
Copy link
Contributor

Fix #32428.

Patch the regex to match ,besides . " ' : and space.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 22, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 22, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 22, 2024
@katsusan
Copy link
Contributor Author

before:
image

after:
image

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 22, 2024 •
edited
Loading

Would you like to add some tests? Or I could help to.

Oops, I must be not awaken, just saw the tests.

Awesome, thank you~~

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 22, 2024
@wxiaoguang wxiaoguang added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Dec 22, 2024
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Dec 22, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 22, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 22, 2024
@lunny lunny enabled auto-merge (squash) December 22, 2024 21:07
@lunny lunny merged commit fb75151 into go-gitea:main Dec 22, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 22, 2024
@katsusan @GiteaBot
fix trailing comma not matched in the case of alphanumeric issue (go-…
3f77f4f 
…gitea#32945)

Fix go-gitea#32428.

Patch the regex to match `,`besides `.` `"` `'` `:` and space.
@GiteaBot GiteaBot mentioned this pull request Dec 22, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 22, 2024
lunny pushed a commit that referenced this pull request Dec 22, 2024
@GiteaBot @katsusan
fix trailing comma not matched in the case of alphanumeric issue (#32945
a8f98fd 
) (#32959)

Backport #32945 by @katsusan

Fix #32428.

Patch the regex to match `,`besides `.` `"` `'` `:` and space.

Co-authored-by: katsu <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 23, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
31173c9 
* giteaofficial/main: (62 commits)
  Fix repo avatar conflict (go-gitea#32958)
  [skip ci] Updated licenses and gitignores
  fix trailing comma not matched in the case of alphanumeric issue (go-gitea#32945)
  Add auto-expanding running actions step (go-gitea#30058)
  Fix go-gitea#32954 (go-gitea#32955)
  Use Alpine 3.21 for the docker images (go-gitea#32924)
  Refactor template & test related code (go-gitea#32938)
  Use primary as button color (go-gitea#32949)
  [skip ci] Updated translations via Crowdin
  Add action auto-scroll (go-gitea#30057)
  Fix locale (go-gitea#32937)
  Enable Typescript `strictFunctionTypes` (go-gitea#32911)
  Fix areYouSure confirm (go-gitea#32941)
  Update i18n.go - Language Picker (go-gitea#32933)
  Move some errors to their own sub packages (go-gitea#32880)
  Improve navbar: add "admin" tip, add "active" style (go-gitea#32927)
  Refactor db package and remove unnecessary `DumpTables` (go-gitea#32930)
  show warning on navigation if currently editing comment or title (go-gitea#32920)
  Refactor pprof labels and process desc (go-gitea#32909)
  [skip ci] Updated translations via Crowdin
  ...
@katsusan katsusan deleted the i32428 branch December 23, 2024 05:56
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 23, 2025
@katsusan
fix trailing comma not matched in the case of alphanumeric issue (go-…
4999de5 
…gitea#32945)

Fix go-gitea#32428.

Patch the regex to match `,`besides `.` `"` `'` `:` and space.

(cherry picked from commit fb75151)
(cherry picked from commit 0efd713)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

External Issue Identifier With Trailing Comma Doesn't Get Linked
4 participants
@katsusan @wxiaoguang @lunny @GiteaBot