Fix Agit pull request permission check #32999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user with read permission should also can create agit flow pull request. looks this logic was broken in go-gitea#31033 this pull request try fix it and add test code. Signed-off-by: a1012112796 <[email protected]>
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Dec 27, 2024
Signed-off-by: a1012112796 <[email protected]>
wxiaoguang
reviewed
Dec 27, 2024
services/pull/pull.go
Outdated
| @@ -64,7 +64,7 @@ func NewPullRequest(ctx context.Context, opts *NewPullRequestOptions) error { | |||
| } | |||
|
|
|||
| // user should be a collaborator or a member of the organization for base repo | |||
| if !issue.Poster.IsAdmin { | |||
| if (!issue.Poster.IsAdmin) && pr.Flow == issues_model.PullRequestFlowGithub { | |||
There was a problem hiding this comment.
Suggested change
| if (!issue.Poster.IsAdmin) && pr.Flow == issues_model.PullRequestFlowGithub { | |
| canCreate := issue.Poster.IsAdmin || pr.Flow == issues_model.PullRequestFlowAGit | |
| if !canCreate { |
But should we also check something like "repo read permission" for "agit" to create?
There was a problem hiding this comment.
But should we also check something like "repo read permission" for "agit" to create?
looks user already can't create pull request in my local test.
Co-authored-by: wxiaoguang <[email protected]>
wxiaoguang
approved these changes
Dec 27, 2024
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Dec 27, 2024
GiteaBot
added
lgtm/done
lunny
approved these changes
Dec 27, 2024
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Dec 27, 2024
user with read permission should also can create agit flow pull request. looks this logic was broken in go-gitea#31033 this pull request try fix it and add test code. --------- Signed-off-by: a1012112796 <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
Dec 28, 2024
Backport #32999 by @a1012112796 user with read permission should also can create agit flow pull request. looks this logic was broken in #31033 this pull request try fix it and add test code. Signed-off-by: a1012112796 <[email protected]> Co-authored-by: a1012112796 <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 30, 2024
* giteaofficial/main: Refactor pagination (go-gitea#33037) Test webhook email (go-gitea#33033) Fix review code comment avatar alignment (go-gitea#33031) Fix templating in pull request comparison (go-gitea#33025) Refactor tests (go-gitea#33021) [skip ci] Updated translations via Crowdin always show assignees on right (go-gitea#33006) fix toggle commit body button ui when latest commit message is long (go-gitea#32997) Fix and/or comment some legacy CSS problems (go-gitea#33015) Refactor comment history and fix content edit (go-gitea#33018) Fix bug on activities (go-gitea#33008) Refactor arch route handlers (go-gitea#32993) fix scoped label ui when contains emoji (go-gitea#33007) [skip ci] Updated translations via Crowdin De-emphasize signed commits (go-gitea#31160) Fix eslint (go-gitea#33002) Fix Agit pull request permission check (go-gitea#32999) Support for email addresses containing uppercase characters when activating user account (go-gitea#32998)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user with read permission should also can create agit flow pull request. looks this logic was broken in #31033 this pull request try fix it and add test code.