Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testfixtures #33028

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Refactor testfixtures #33028

merged 2 commits into from
Dec 30, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 29, 2024 •
edited
Loading

Partial backport of #33024

@GiteaBot GiteaBot added this to the 1.23.0 milestone Dec 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/dependencies labels Dec 29, 2024
@wxiaoguang wxiaoguang force-pushed the backport-testfixtures branch from d38b87c to 2064d07 Compare December 29, 2024 06:07
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 29, 2024
@wxiaoguang wxiaoguang requested a review from delvh December 29, 2024 15:18
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 30, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 30, 2024
@lunny lunny enabled auto-merge (squash) December 30, 2024 02:25
@lunny lunny merged commit ce6a60a into go-gitea:release/v1.23 Dec 30, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 30, 2024
@wxiaoguang wxiaoguang deleted the backport-testfixtures branch December 30, 2024 04:53
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @techknowlogick @GiteaBot