fix empty repo updated time

[changchaishi]

fixes #33119

routers/web/repo/view_home.go

Calling updateContextRepoEmptyAndStatus will always ask the DB to update the updated Unix attributes.
When revisiting the repo's home page, the timestamp will be updated unexpectedly, so I added the needsUpdate variable to check whether, in the end, the commitment to db update is necessary if columns have not changed at all.

[lunny]

Since it's not a real update, we should use xorm's NoAutoTime to update the record to avoid updated time change.

[changchaishi]

Hi @lunny,

I have three scenarios in mind:

1. Use NoAutoTime from an extra parameter UpdateRepositoryCols, but there are 23 calls to this function to the codebase.
2. Add a new function like UpdateRepositoryColsNoAutoTime <- something like this
3. Stick with current fix. Will this save the DB round trip?
4. Access DB directly from updateContextRepoEmptyAndStatus, least code change and it is like combination of 2 and 3

I updated the code to use 4. Please review if this is ok.

[lunny]

Hi @lunny,

I have three scenarios in mind:

1. Use `NoAutoTime` from an extra parameter `UpdateRepositoryCols`, but there are 23 calls to this function to the codebase.

2. Add a new function like `UpdateRepositoryColsNoAutoTime` <- something like this

3. Stick with current fix. Will this save the DB round trip?

4. Access DB directly from `updateContextRepoEmptyAndStatus`, least code change and it is like combination of 2 and 3

I updated the code to use 4. Please review if this is ok.

I prefer solution 2.

[changchaishi]

Updated.