-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the new exit code for git remote
subcommands for git version >=2.30.0
#33129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git remote
subcommands in new git versiongit remote
subcommands for git version >=2.30.0
lunny
reviewed
Jan 7, 2025
lunny
approved these changes
Jan 7, 2025
wxiaoguang
reviewed
Jan 7, 2025
wxiaoguang
reviewed
Jan 7, 2025
Co-authored-by: wxiaoguang <[email protected]>
wxiaoguang
approved these changes
Jan 7, 2025
I was unable to create a backport for 1.23. @yp05327, please send one manually. 🍵
|
wxiaoguang
pushed a commit
to wxiaoguang/gitea
that referenced
this pull request
Jan 7, 2025
…n >=2.30.0 (go-gitea#33129) Fix go-gitea#32889 --------- Co-authored-by: wxiaoguang <[email protected]> # Conflicts: # modules/git/remote.go
This was referenced Jan 8, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 8, 2025
* giteaofficial/main: add submodule diff links (go-gitea#33097) [skip ci] Updated translations via Crowdin Update status check for all supported on.pull_request.types in Gitea (go-gitea#33117) Support the new exit code for `git remote` subcommands for git version >=2.30.0 (go-gitea#33129) Make git clone URL could use current signed-in user (go-gitea#33091) Filter reviews of one pull request in memory instead of database to reduce slow response because of lacking database index (go-gitea#33106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/done
All backports for this PR have been created
backport/manual
No power to the bots! Create your backport yourself!
backport/v1.23
This PR should be backported to Gitea 1.23
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32889
The root reason can be found in: #32889 (comment)
ps: how to test it in CI? I have tested the issue mentioned in #32889 by manually remove the remote and I see the 500 error and this PR can fix it in this case.