Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context usage #33554

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix context usage #33554

merged 2 commits into from
Feb 11, 2025

Conversation

wxiaoguang
Copy link
Contributor

Some old code use direct type-casting to get context, it causes problems.

This PR fixes all legacy problems and use correct ctx.Value to get low-level contexts.

Fix #33518

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 11, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 11, 2025
@wxiaoguang wxiaoguang mentioned this pull request Feb 11, 2025
Closed
@wxiaoguang wxiaoguang added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Feb 11, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Feb 11, 2025
@wxiaoguang wxiaoguang mentioned this pull request Feb 11, 2025
Merged
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2025
@wxiaoguang wxiaoguang merged commit 245ac32 into go-gitea:main Feb 11, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-markup-context branch February 11, 2025 08:46
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.23. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 33554
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 11, 2025
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Feb 11, 2025
@wxiaoguang
Fix context usage (go-gitea#33554)
df847a0
@wxiaoguang wxiaoguang mentioned this pull request Feb 11, 2025
Merged
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Feb 11, 2025
wxiaoguang added a commit that referenced this pull request Feb 11, 2025
@wxiaoguang
Fix context usage (#33554) (#33557)
8fa3925 
Backport #33554
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 12, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
772feea 
* giteaofficial/main:
  Add a transaction to `pickTask` (go-gitea#33543)
  Fix context usage (go-gitea#33554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Mentions in comments (@User) no longer highlighted
4 participants
@wxiaoguang @GiteaBot @lunny @yardenshoham