Skip to content
/ gitea Public
  • Sponsor go-gitea/gitea

  • Notifications You must be signed in to change notification settings
  • Fork 5.7k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance routers for the Actions runner operations (#33549) #33555

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 11, 2025

Backport #33549

  • Find the runner before deleting
  • Move the main logic from routers/web/repo/setting/runners.go to routers/web/shared/actions/runners.go.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
- Find the runner before deleting
- Move the main logic from `routers/web/repo/setting/runners.go` to
`routers/web/shared/actions/runners.go`.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@lunny lunny added this to the 1.23.4 milestone Feb 11, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 11, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 11, 2025
@lunny lunny requested a review from wxiaoguang February 11, 2025 06:19
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 11, 2025
@lunny lunny requested a review from Zettat123 February 11, 2025 06:19
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 11, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2025
@wolfogre wolfogre merged commit 7794ff0 into go-gitea:release/v1.23 Feb 11, 2025
26 checks passed
@lunny lunny deleted the lunny/backport_33549 branch February 11, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants