Pull request updates will also trigger code owners review requests #33744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
added
type/bug
backport/v1.23
a1012112796
approved these changes
Feb 28, 2025
GiteaBot
added
lgtm/need 1
metiftikci
reviewed
Feb 28, 2025
pull-request-size
bot
added
the
size/M
jpraet
reviewed
Mar 1, 2025
wxiaoguang
reviewed
Mar 3, 2025
wxiaoguang
reviewed
Mar 3, 2025
lunny
added a commit
that referenced
this pull request
Mar 4, 2025
Wait tomorrow's Golang version. Maybe wait backport of #33764 and #33744, #33789 --------- Co-authored-by: metiftikci <[email protected]>
pull-request-size
bot
added
size/L
lunny
changed the title
wxiaoguang
reviewed
Mar 12, 2025
wxiaoguang
reviewed
Mar 12, 2025
services/pull/pull.go
Outdated
| RepoID int64 | ||
| Doer *user_model.User | ||
| Branch string | ||
| IsSync bool |
There was a problem hiding this comment.
What does IsSync mean? Could it have some comments?
There was a problem hiding this comment.
IsSync means if it's a pull request update.
There was a problem hiding this comment.
Then what does IsSync=false mean? Which action triggers IsSync=false? Could it have some comments?
There was a problem hiding this comment.
I have added comments in f8b02f7. Looks like AddTestPullRequestTask needs a big refactor. So that I don't want to introduce it to this PR.
There was a problem hiding this comment.
By that comment, I can understand if IsSync=true then it's a pull request synchronization.
But if IsSync=false, then what it is?Which action triggers IsSync=false?
There was a problem hiding this comment.
4961418
This maybe should be an action parameter. It could be pull request synchronization, updating or merging.
…y/gitea into lunny/add_reviewer_notifier_pr_sync
wxiaoguang
approved these changes
Mar 13, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
…y/gitea into lunny/add_reviewer_notifier_pr_sync
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 14, 2025
* giteaofficial/main: Pull request updates will also trigger code owners review requests (go-gitea#33744) [skip ci] Updated translations via Crowdin remove context from retry downloader (go-gitea#33871) Fine tune push mirror UI (go-gitea#33866) Fix markdown render (go-gitea#33870) Improve issue & code search (go-gitea#33860)
|
I was unable to create a backport for 1.23. @lunny, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Mar 28, 2025
…o-gitea#33744) Fix go-gitea#33490 It will only read the changed file on the pushed commits but not all the files of this PR. --------- Co-authored-by: wxiaoguang <[email protected]>
lunny
added a commit
that referenced
this pull request
Mar 28, 2025
…33744) (#34045) Fix #33490 Backport #33744 It will only read the changed file on the pushed commits but not all the files of this PR. Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33490
It will only read the changed file on the pushed commits but not all the files of this PR.