Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore trivial errors when updating push data (#33864) #33887

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Mar 14, 2025

Backport #33864 by wxiaoguang

Fix #23213

This block is only used for sending notifications, and it is executed after the git repo has been successfully pushed. So we could safely ignore the error.

By the way, remove another useless warning: unknown whitespace behavior: %q, default to 'show-all'. That parameter is provided by the end user, no need to warn that.

@GiteaBot GiteaBot added the modifies/go Pull requests that update Go code label Mar 14, 2025
@GiteaBot GiteaBot requested review from delvh and lunny March 14, 2025 15:11
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2025
@GiteaBot GiteaBot added this to the 1.23.6 milestone Mar 14, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 14, 2025 15:18
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2025
@wxiaoguang wxiaoguang merged commit be94f7b into go-gitea:release/v1.23 Mar 14, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants