Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to figure out attribute checker problem (#33901) #33902

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Try to figure out attribute checker problem (#33901) #33902

merged 1 commit into from
Mar 17, 2025

Conversation

wxiaoguang
Copy link
Contributor

Backport #33901

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2025
@GiteaBot GiteaBot added this to the 1.23.6 milestone Mar 16, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 16, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 16, 2025
@wxiaoguang wxiaoguang mentioned this pull request Mar 16, 2025
Closed
@wxiaoguang wxiaoguang force-pushed the fix-attr-checker-backport branch 2 times, most recently from aac2193 to 7cb33b7 Compare March 16, 2025 05:42
@wxiaoguang wxiaoguang force-pushed the fix-attr-checker-backport branch from 7cb33b7 to d7597bc Compare March 16, 2025 05:55
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2025
@lunny lunny merged commit 9228063 into go-gitea:release/v1.23 Mar 17, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2025
@wxiaoguang wxiaoguang deleted the fix-attr-checker-backport branch March 17, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.6
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot