Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor organization menu #33928

Merged
merged 28 commits into from
Apr 10, 2025
Merged

refactor organization menu #33928

merged 28 commits into from
Apr 10, 2025

Conversation

ExplodingDragon
Copy link
Contributor

@ExplodingDragon ExplodingDragon commented Mar 18, 2025 •
edited
Loading

Fix missing items in organization menu.

Menu

Show

Before:

After:

Packages

keep it consistent with the other pages.

Show

Before:

After:

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 18, 2025
@ExplodingDragon ExplodingDragon changed the title Fix org menu Title Fix org menu items Mar 18, 2025
@ExplodingDragon ExplodingDragon changed the title Fix org menu items Fix missing items in organization menu Mar 18, 2025
@ExplodingDragon ExplodingDragon marked this pull request as ready for review March 18, 2025 09:28
@lunny lunny added the type/bug label Mar 19, 2025
@lunny
Copy link
Member

lunny commented Mar 19, 2025

image
Org Code UI still missed the overview tab.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 20, 2025
@ExplodingDragon ExplodingDragon marked this pull request as draft March 20, 2025 01:35
@wxiaoguang wxiaoguang mentioned this pull request Apr 6, 2025
Closed
@wxiaoguang
Copy link
Contributor

Is this PR active? Maybe it's good to have it in 1.24, ps: a recent similar PR:

@ExplodingDragon ExplodingDragon marked this pull request as ready for review April 8, 2025 02:21
@wxiaoguang
Copy link
Contributor

Thank you very much. I will try to add some asserts to make sure there won't be new regression in the future. Let me try.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 8, 2025 •
edited
Loading

Found more problems in old code. A lot of duplicate calls. Maybe we need to do more refactoring.

image

image

image

The mess started from "Count only visible repos on profile (#25928)", after that PR, the code is keeping being patched and copied-pasted.

@ExplodingDragon ExplodingDragon changed the title Fix missing items in organization menu & refactor org menu Fix organization menu and packages details & refactor org menu Apr 8, 2025
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Apr 8, 2025
@ExplodingDragon ExplodingDragon marked this pull request as ready for review April 8, 2025 08:58
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 9, 2025
@yp05327
Copy link
Contributor

yp05327 commented Apr 9, 2025

image
New Project page missing tags

@ExplodingDragon ExplodingDragon changed the title Fix organization menu and packages details & refactor org menu refactor organization menu Apr 10, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2025
@lunny lunny added this to the 1.24.0 milestone Apr 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 10, 2025
@lunny lunny merged commit 4ddf94d into go-gitea:main Apr 10, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 10, 2025
@ExplodingDragon ExplodingDragon deleted the fix-tmpl branch April 11, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ExplodingDragon @lunny @wxiaoguang @yp05327 @hiifong @techknowlogick @GiteaBot