-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC provider #33945
base: main
Are you sure you want to change the base?
OIDC provider #33945
Conversation
This depends on a few changes in act and act_runner: https://gitea.com/gitea/act_runner/pulls/272 https://gitea.com/gitea/act/pulls/73
Referencing it could cause inconsistencies if it changes later.
@@ -0,0 +1,221 @@ | |||
// Copyright 2022 The Gitea Authors. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this file is actually needed - in the original PR there was just a small change to its logic, but it looks like the file has been entirely deleted in the main branch of the repo. I think it can be deleted entirely, but I'll keep it around until either a) I can get more confidence in that position, or b) someone more knowledgeable about the codebase can confirm that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been moved in a recent PR. Maybe you could try to find when it is deleted. https://stackoverflow.com/questions/6839398/find-when-a-file-was-deleted-in-git
Hmm - I'm getting error:
but when I run that command, I get
I'm guessing that some names changed between the time this code was originally written and now. I'll keep poking around! |
It is |
This will not build until [this PR](https://gitea.com/gitea/act/pulls/73) (which adds `SingleWorkflow.RawPermissions`) is merged.
Note that building will still fail until this PR is merged, since it adds a EDIT: re-opened here. |
As requested [here](go-gitea#33945 (comment)).
I re-opened the PRs on act and act_runner which are dependencies of this one. Hopefully 🤞🏻 those should be smooth to merge (since it looks like the originals were already approved), at which point I can iron out the rest of the build/lint failures. Thanks for the assistance/attention so far! 🙏🏻 |
This adds support for a Github Actions compatible OIDC provider.
For more info, see:
https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect
It depends on a few changes in act and act_runner:
https://gitea.com/gitea/act_runner/pulls/272
https://gitea.com/gitea/act/pulls/73
The above is the summary of the original PR that this sprang from. It looks like that one (which has been open for nearly 2 years) has lost steam after the original contributor got frustrated with delays, so I'm hoping that opening a fresh PR will revitalize the effort.
To be extremely clear: