Storing branch commits count in db rather than caching them in memory or redis #33954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/api
wxiaoguang
reviewed
Mar 21, 2025
modules/gitrepo/commit.go
Outdated
| return nil, err | ||
| } | ||
| defer gitRepo.Close() | ||
| return gitRepo.GetCommit(commitID) |
There was a problem hiding this comment.
You can not do this! You can not close the gitRepo then then access the returned "commit"!!!!
That's I said many times: I do not see how you could make the "gitrepo" package work correctly, but introducing more bugs.
wxiaoguang
requested changes
Mar 21, 2025
GiteaBot
added
lgtm/blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch commit counts are cached in memory or Redis after the first access. However, the initial page load is still slow because the commit count needs to be computed.
This PR introduces a new field in the database to store commit counts for branches. The commit count is updated automatically when branches are pushed or mirrored. Additionally, a background task periodically checks and corrects any discrepancies in the commit count to handle unexpected situations.
With this change, even if the commit count is not updated in time, a number will still be displayed in the UI. This prevents the UI from blocking the user, as commit counts are generally not critical for the user’s experience when visiting the page.
Note: The
releasetable has a columnnum_commitswhich stored the commit count of a tag. So that we just need to cache a commit's commit count in the cache.