Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare common tmpl functions in a middleware #33957

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix the TODO in routers/web/web.go, and avoid the unnecessary GetActiveStopwatch SQL query in non-related route handlers.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 21, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 21, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 21, 2025
@wxiaoguang
Copy link
Contributor Author

image

@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 21, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 21, 2025
@wxiaoguang wxiaoguang force-pushed the refactor-route-middleware branch from 678be73 to a57efe0 Compare March 21, 2025 03:19
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 21, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 25, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 25, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 25, 2025 05:47
@wxiaoguang wxiaoguang merged commit 41c946a into go-gitea:main Mar 25, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 25, 2025
@wxiaoguang wxiaoguang deleted the refactor-route-middleware branch March 25, 2025 06:52
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 26, 2025
* giteaofficial/main:
  Enable color output in govulncheck (go-gitea#34012)
  Update Makefile test comments (go-gitea#34013)
  Move duplicated functions (go-gitea#33977)
  Git client will follow 301 but 307 (go-gitea#34005)
  Prepare common tmpl functions in a middleware (go-gitea#33957)
  Update go mod dependencies (go-gitea#33988)
  Fix some migration and repo name problems (go-gitea#33986)
  [skip ci] Updated translations via Crowdin
  Use filepath.Join instead of path.Join for file system file operations (go-gitea#33978)
  Add changelog for 1.23.6 (go-gitea#33975)
  Fix incorrect code search indexer options (go-gitea#33992)
  Auto expand "New PR" form (go-gitea#33971)
  Move ParseBool to optional (go-gitea#33979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants