Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto expand "New PR" form #33971

Merged
merged 4 commits into from
Mar 24, 2025
Merged

Auto expand "New PR" form #33971

merged 4 commits into from
Mar 24, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 22, 2025 •
edited
Loading

Follow GitHub's behavior: use ?expand=1 to expand the "New PR" form

The old .Flash check is not needed anymore because now we use "fetch action form", no flash message.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 22, 2025
@wxiaoguang
Copy link
Contributor Author

image

image

image

image

@wxiaoguang wxiaoguang mentioned this pull request Mar 22, 2025
Closed
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Mar 22, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 22, 2025
@silverwind
Copy link
Member

silverwind commented Mar 22, 2025 •
edited
Loading

Will this also work for the links that are output when pushing to a new branch over SSH? GitHub uses a special URL scheme like repo/pulls/new/branch which redirects to a auto-expanded compare page. I think it's using a ?-less URL so its easier to copy from terminal.

I would strongly prefer if we have that URL too and it could be used for this "Open PR" button.

@wxiaoguang
Copy link
Contributor Author

Will this also work for the links that are output when pushing to a new branch over SSH?

I do not know where it is (I don't use it).

So feel free to add it in this PR or improve it in the future.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2025
@silverwind
Copy link
Member

silverwind commented Mar 24, 2025 •
edited
Loading

Will this also work for the links that are output when pushing to a new branch over SSH?

I do not know where it is (I don't use it).

So feel free to add it in this PR or improve it in the future.

It's the message that shows for the first time when pushing to a branch:

$ git checkout -b test
branch 'test' set up to track 'master' by rebasing.
Switched to a new branch 'test'
$ git commit --allow-empty -m 'test'
[test 3bbb14a] test
$ git push origin test
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 367 bytes | 183.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
remote:
remote: Create a new pull request for 'test':
remote:   https://gitea.com/org/repo/compare/master...test  <----
remote:
remote: . Processing 1 references
remote: Processed 1 references in total
To gitea.com:org/repo.git
 * [new branch]      test -> test

@silverwind
Copy link
Member

silverwind commented Mar 24, 2025 •
edited
Loading

FYI, here is the same link that GitHub produces:

remote:
remote: Create a pull request for 'test2' on GitHub by visiting:
remote:      https://github.com/silverwind/gitea/pull/new/test2
remote:

When opening the link https://github.com/silverwind/gitea/pull/new/test2, it redirects to https://github.com/go-gitea/gitea/compare/main...silverwind:gitea:test2?expand=1, e.g. the expanded compare page.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2025
@wxiaoguang
Copy link
Contributor Author

When opening the link https://github.com/silverwind/gitea/pull/new/test2, it redirects to https://github.com/go-gitea/gitea/compare/main...silverwind:gitea:test2?expand=1, e.g. the expanded compare page.

f1b1264

silverwind
silverwind approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 24, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 24, 2025 14:05
@wxiaoguang wxiaoguang merged commit b1e326d into go-gitea:main Mar 24, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-pr-form branch March 24, 2025 14:31
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 26, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6d8eaa4 
* giteaofficial/main:
  Enable color output in govulncheck (go-gitea#34012)
  Update Makefile test comments (go-gitea#34013)
  Move duplicated functions (go-gitea#33977)
  Git client will follow 301 but 307 (go-gitea#34005)
  Prepare common tmpl functions in a middleware (go-gitea#33957)
  Update go mod dependencies (go-gitea#33988)
  Fix some migration and repo name problems (go-gitea#33986)
  [skip ci] Updated translations via Crowdin
  Use filepath.Join instead of path.Join for file system file operations (go-gitea#33978)
  Add changelog for 1.23.6 (go-gitea#33975)
  Fix incorrect code search indexer options (go-gitea#33992)
  Auto expand "New PR" form (go-gitea#33971)
  Move ParseBool to optional (go-gitea#33979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot