when using rules to delete packages, remove unclean bugs #34632
+34
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
Please add some tests |
added 5 commits
June 9, 2025 13:55
lunny
approved these changes
Jun 12, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Jun 17, 2025
GiteaBot
added
lgtm/done
wxiaoguang
reviewed
Jun 17, 2025
| defer committer.Close() | ||
|
|
||
| err = packages_model.IterateEnabledCleanupRules(ctx, func(ctx context.Context, pcr *packages_model.PackageCleanupRule) error { | ||
| return packages_model.IterateEnabledCleanupRules(outerCtx, func(ctx context.Context, pcr *packages_model.PackageCleanupRule) error { |
There was a problem hiding this comment.
Why the db.TxContext? outerCtx seems to be a bug
wxiaoguang
reviewed
Jun 17, 2025
| count, err := sess.FindAndCount(&pvs) | ||
| return pvs, count, err | ||
| err := sess.Find(&pvs) | ||
| return pvs, int64(len(pvs)), err |
There was a problem hiding this comment.
Why the behavior is changed? The root problem is how we should treat the "count": does it have a clear meaning like "the total count in database"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the code extracts 200 package versions. If too many packages are generated every day or if rule cleaning is enabled later, which means there are more than 200 versions corresponding to the library package, it may not be cleaned up completely, resulting in residue