Skip to content

fix: Improve image captcha contrast for dark mode #36265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majiayu000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Improve image captcha contrast for dark mode #36265

majiayu000 wants to merge 1 commit into from
+11 −0

Conversation

@majiayu000
Copy link

@majiayu000 majiayu000 commented Dec 30, 2025

Summary

This PR fixes #36255

The image captcha was using random colors which often resulted in poor contrast against dark backgrounds, making it difficult or impossible for users to read in dark mode.

Changes

  • Added a custom color palette to the image captcha configuration in services/context/captcha.go
  • The palette uses high-contrast colors (bright red, blue, green, yellow, purple, and dark blue-gray) that provide good visibility in both light and dark themes
  • This improves accessibility and user experience without changing any existing functionality

Testing

  • Builds successfully
  • All existing tests pass
  • The color palette is properly supported by the upstream gitea.com/go-chi/captcha library

Generated with Claude Code

@majiayu000
Fix image captcha low contrast in dark mode
3921fa3 
The image captcha was using random colors which often resulted
in poor contrast against dark backgrounds, making it difficult
or impossible for users to read in dark mode.

This fix configures a color palette with high-contrast colors
that provide good visibility in both light and dark themes,
improving accessibility and user experience.

Fixes go-gitea#36255

Signed-off-by: majiayu000 <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 30, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Image captcha results in low contrast challenge in dark mode

2 participants

@majiayu000 @GiteaBot