prefer ReleaseAsset DownloadFunc and add migration client coverage#36800
Open
lunny wants to merge 5 commits intogo-gitea:mainfrom
Open
prefer ReleaseAsset DownloadFunc and add migration client coverage#36800lunny wants to merge 5 commits intogo-gitea:mainfrom
lunny wants to merge 5 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
wxiaoguang
requested changes
Mar 2, 2026
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
I have told you.
"httplib creates a new Client every request #6764"
GiteaBot
added
lgtm/blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DownloadFuncwhen exporting release assets; fall back to the migration-filtered HTTP client forDownloadURL, and error when neither is provided.DownloadFuncprecedence and thatDownloadURLuses the migration client to block disallowed domains.