Replace index with id in actions routes

[Zettat123]

This PR migrates the web Actions run/job routes from index-based runIndex or jobIndex to database IDs.

⚠️ BREAKING ⚠️: Existing saved links/bookmarks that use the old index-based URLs will no longer resolve after this change.

Improvements of this change:

• Previously, jobIndex depended on list order, making it hard to locate a specific job. Using jobID provides stable addressing.
• Web routes now align with API, which already use IDs.
• Behavior is closer to GitHub, which exposes run/job IDs in URLs.
• Provides a cleaner base for future features without relying on list order.
  • WIP: Improve support for reusable workflows #36388 this PR improves the support for reusable workflows. If a job uses a reusable workflow, it may contain multiple child jobs, which makes relying on job index to locate a job much more complicated

[bircni]

Cool

[Copilot]

Pull request overview

Migrates the repository web UI Actions run/job routes from index-based identifiers (runIndex/jobIndex) to stable database IDs (runID/jobID), aligning the web routes with the API and enabling more reliable addressing (especially with reusable workflows/child jobs).

Changes:

• Update frontend components/templates to pass and consume runId/jobId, and generate /actions/runs/{runID}/jobs/{jobID} links.
• Update backend web handlers and helpers to resolve runs/jobs by repo+ID (and run+job ID) and adjust log/rerun/cancel/approve/delete endpoints accordingly.
• Update and extend integration/unit tests to reflect ID-based URLs and add coverage for cross-repo run/job access protections.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
web_src/js/features/repo-actions.ts	Pass runId/jobId props into the Actions view Vue app.
web_src/js/components/WorkflowGraph.vue	Switch “current job” selection and job links from index to job ID.
web_src/js/components/RepoActionView.vue	Update API calls and UI links (jobs, logs, rerun) to use IDs.
templates/repo/actions/view_component.tmpl	Replace data-run-index/data-job-index with data-run-id/data-job-id.
templates/repo/actions/view.tmpl	Pass RunID/JobID into the view component instead of indexes.
templates/devtest/repo-action-view.tmpl	Update devtest template wiring to use RunID/JobID.
routers/web/repo/actions/view.go	Rework run/job resolution and all related endpoints (view/post/logs/rerun/cancel/approve/delete) to use IDs.
routers/web/devtest/mock_actions.go	Update devtest mock handler data keys to RunID/JobID.
routers/common/actions.go	Replace “download logs by job index” helper with “by job ID” helper.
routers/api/v1/repo/actions_run.go	Scope job-log download lookup by repo+job ID.
routers/api/v1/repo/action.go	Return Actions dispatch HTMLURL using run ID instead of run index.
services/convert/convert.go	Update webhook/API conversion to emit job HTMLURL using job ID.
services/actions/rerun.go	Ensure run attributes are loaded before rerun logic continues (needed for downstream usage).
services/actions/commit_status.go	Update commit-status target URLs and parsing/lookup paths to use IDs.
models/actions/run.go	Change ActionRun HTMLURL()/Link() to use run database ID.
models/actions/run_job.go	Replace GetRunJobByID with repo/run-scoped getters; adjust UpdateRunJob reload path accordingly.
models/actions/task.go	Ensure job loading and run-job updates are repo-scoped; include RepoID when updating jobs from tasks.
models/git/commit_status_test.go	Update Actions target URL test fixture to the new /runs/{id}/jobs/{id}-style pattern.
tests/integration/repo_webhook_test.go	Update expected webhook HTMLURL and UI endpoints to use run/job IDs.
tests/integration/api_actions_run_test.go	Update job lookup helpers in API rerun tests to be run-scoped.
tests/integration/actions_rerun_test.go	Update rerun endpoints to use run/job IDs.
tests/integration/actions_log_test.go	Update log download paths to use run/job IDs derived from tasks.
tests/integration/actions_delete_run_test.go	Resolve run ID from run number and update all URLs to use run/job IDs.
tests/integration/actions_concurrency_test.go	Update approve/rerun/cancel/job rerun URLs to use IDs; adjust assertions accordingly.
tests/integration/actions_route_test.go	New integration test validating repo scoping and 404 behavior for mismatched run/job IDs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Zettat123]

Since the legacy CommitStatus.TargetURL was generated based on runIndex and jobIndex, those URLs will become invalid after this change.

gitea/services/actions/commit_status.go

Lines 190 to 197 in eb020a9

	status := git_model.CommitStatus{
	SHA: commitID,
	TargetURL: fmt.Sprintf("%s/jobs/%d", run.Link(), index),
	Description: description,
	Context: ctxName,
	CreatorID: creator.ID,
	State: state,
	}

I’ve added a migration to convert all legacy TargetURLs into id-based URLs. This migration also addresses the issue in #36842 (comment)

[silverwind]

Review by Claude on behalf of @silverwind

1. getRunJobsAndCurrentJob no longer sets .Run on jobs — The old getRunJobs had a for _, v := range jobs { v.Run = run } loop that's removed now. If any downstream code (e.g. convertToViewModel, CancelJobs) accesses job.Run on jobs from this list, it will be nil. Needs verification.

2. approve returns 500 instead of 404 for cross-repo access — Every other cross-repo case in the new route test correctly expects 404, but approve expects 500. The approveRuns function doesn't distinguish util.ErrNotExist from internal errors inside its db.WithTx call. Should be 404 for consistency and to avoid leaking information.

3. Migration cache inconsistency in getRunByIndexCached — First miss returns (nil, error), subsequent misses for the same key return (nil, nil) because nil is cached as the value. The caller handles both cases so it works, but it's surprising behavior.