fix(web): attachment remove control renders as javascript:undefined link - #38840
Open
aryamohammadi wants to merge 1 commit into
Open
fix(web): attachment remove control renders as javascript:undefined link#38840aryamohammadi wants to merge 1 commit into
aryamohammadi wants to merge 1 commit into
Conversation
Dropzone's addRemoveLinks option hardcodes the remove control as an anchor with href="javascript:undefined;", which shows a meaningless URL on hover and announces a fake link to assistive technology. Render the control as a real button instead and keep the file._removeLink reference so dropzone can still swap its label during uploads. Assisted-by: Claude Code:claude-opus-5
GiteaBot
added
the
lgtm/need 2
wxiaoguang
requested changes
Aug 9, 2026
GiteaBot
added
lgtm/blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #38802
Dropzone's addRemoveLinks option hardcodes the remove control as an anchor with href="javascript:undefined;", which shows a meaningless URL on hover and announces a fake link to assistive technology. Render the control as a real button instead and keep the file._removeLink reference so dropzone can still swap its label during uploads.
Before:
After:
Assisted-by: Claude Code:claude-opus-5