fix(api): allow read-only pull request access for fork PR Actions token #38444 - #38889
Open
gomitrah wants to merge 2 commits into
Open
fix(api): allow read-only pull request access for fork PR Actions token #38444#38889gomitrah wants to merge 2 commits into
gomitrah wants to merge 2 commits into
Conversation
GiteaBot
added
the
lgtm/need 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actions tokens for workflows triggered by a fork pull request were
clamped to a permission set with no access to Issues/PullRequests at
all, even when the workflow runs against its own base repo. This made
mustAllowPullsreject any PR API call (e.g. listing PR reviews) forfork-triggered CI jobs with a 404, while identical calls from non-fork
PRs succeeded.
Fork PR tokens are documented as being restricted to read-only access,
not no access. This adds a dedicated read-only permission ceiling for
the fork-PR/cross-repo clamp instead of reusing the admin-configured
"Restricted" mode preset (which intentionally excludes Issues/PRs and
must stay unchanged).
Fixes #38444