Fix null setting on reused objects #6837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from v1.25.1 gorm seems to not reset null fields, causing incosistent behavior with previous behavior.
turip
commented
Feb 13, 2024
| if test.ID%2 == 0 { | ||
| AssertEqual(t, test.ScannerValue, NewDummyString("")) | ||
| AssertEqual(t, test.NullScannerValue, nil) | ||
| AssertEqual(t, test.IntValue, int(0)) |
There was a problem hiding this comment.
This is still problematic:
-- FAIL: TestScanNilHandling (9.77s)
utils.go:40: /Users/turip/src/gorm/tests/scan_test.go:295: expect: 0, got 1
utils.go:40: /Users/turip/src/gorm/tests/scan_test.go:295: expect: 0, got 3
utils.go:40: /Users/turip/src/gorm/tests/scan_test.go:295: expect: 0, got 5
utils.go:40: /Users/turip/src/gorm/tests/scan_test.go:295: expect: 0, got 7
|
This PR is being closed due to failed tests. |
|
Just came here to say that I've also concluded that this is problem for us and it's not 100% clear to me what the previous PR was trying to solve. Will try and get another PR up to fix this but will also make sure I understand completely what's going on first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Starting from v1.25.1 GORM seems to not reset null fields, causing incosistent behavior compared to the previous way GORM was working.
The fixes I have added are fixing this for Scanner interfaces and time.Time, however there's still a test failure in case of the int and most likely other primitive variables.
I am opening this PR just to illustrate the fixes, but I think we need to debate it further what's the expected behavior.
User Case Description