fix: fix some base32 parsing issues by using go standard library instead of regex #1286
+47
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
approved these changes
Jun 26, 2024
nodivbyzero
approved these changes
Dec 9, 2024
Contributor
nodivbyzero
left a comment
nodivbyzero
left a comment
There was a problem hiding this comment.
LGTM
Here are the benchmarks:
goos: darwin
goarch: arm64
pkg: github.com/go-playground/validator/v10
cpu: Apple M1
BenchmarkRegexValidation-8 3 077 074 360.4 ns/op 0 B/op 0 allocs/op
PASS
ok github.com/go-playground/validator/v10 1.932s
vs.
goos: darwin
goarch: arm64
pkg: github.com/go-playground/validator/v10
cpu: Apple M1
BenchmarkDecodingValidation-8 9 891 073 121.9 ns/op 48 B/op 3 allocs/op
PASS
ok github.com/go-playground/validator/v10 2.586s
zemzale
approved these changes
Dec 10, 2024
Member
zemzale
left a comment
zemzale
left a comment
There was a problem hiding this comment.
One less regex is a win in my books. LGTM
alob-mtc
approved these changes
Jul 15, 2025
deankarn
approved these changes
Dec 24, 2025
Contributor
|
LGTM would you be able to resolve the conflicts, I then will merge this @jamesatkin-myndup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Some strings were failing to be parsed by the previous RegEx based validation. This now uses the Go
base32module (part of the standard library) to more reliably decode the field.Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers