Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Solana cNFT Transfers #13

Merged
merged 17 commits into from
Dec 8, 2024
Merged

Plugin: Solana cNFT Transfers #13

merged 17 commits into from
Dec 8, 2024

Conversation

bryan-eastwood3
Copy link
Collaborator

@bryan-eastwood3 bryan-eastwood3 commented Dec 6, 2024 •
edited
Loading

Adds a plugin to allow AI agents to transfer cNFTs from their wallets. Contains a few changes to the Solana wallet code to fix incompatibilities with our API.
Tested e2e

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ff8b9ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

aigustin
aigustin requested changes Dec 6, 2024
View reviewed changes
@bryan-eastwood3 bryan-eastwood3 marked this pull request as draft December 6, 2024 22:29
@bryan-eastwood3 bryan-eastwood3 marked this pull request as ready for review December 7, 2024 22:34
0xaguspunk
0xaguspunk approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@0xaguspunk 0xaguspunk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Made two small comments on naming and on the examples. Otherwise lgtm!

One thing we are missing is bumping the version and running changesets. Since we need to release the nfts package and crossmint one

@0xaguspunk 0xaguspunk merged commit 5805130 into main Dec 8, 2024
1 check passed
@0xaguspunk 0xaguspunk deleted the feature/solana-cnft-transfers branch December 8, 2024 20:17
youssefea pushed a commit to youssefea/goat that referenced this pull request Dec 17, 2024
@bryan-eastwood3 @youssefea
Plugin: Solana cNFT Transfers (goat-sdk#13)
1547668 
* changes

* changes

* changes

* changes

* changes

* fix formatter

* more diff fixing

* changes

* changes

* temp example

* changes

* fix build

* changes

* fix

* changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonso-paella alfonso-paella alfonso-paella left review comments

@0xaguspunk 0xaguspunk 0xaguspunk approved these changes

@aigustin aigustin aigustin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bryan-eastwood3 @0xaguspunk @alfonso-paella @aigustin