Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added MSQTracker to testing #5420

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added MSQTracker to testing #5420

wants to merge 4 commits into from
+6 −0

Conversation

bunnycou
Copy link

@bunnycou bunnycou commented Feb 3, 2025

No description provided.

@bleatbot bleatbot enabled auto-merge (squash) February 3, 2025 17:13
@bleatbot
Copy link
Collaborator

bleatbot commented Feb 3, 2025 •
edited
Loading

Outdated attempt

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 5 hours.

Name Commit Status
❌ MSQTracker [testing-live] 798b591 Build failed (Diff)
11 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
NuGet HtmlAgilityPack 1.11.72 ⚠️ Upd. from 1.11.54
NuGet HtmlAgilityPack.CssSelectors.NetCore 1.2.1 ⚠️ NEW
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added new plugin This is a new plugin. build failed This plugin failed to build. labels Feb 3, 2025
@philpax
Copy link
Contributor

philpax commented Feb 3, 2025

You don't have to close the PRs 😅

The issue is that your project_path has FFXIV in it, but the project folder (https://github.com/bunnycou/MSQTrackerFFXIV/tree/main/MSQTracker) doesn't. It should build once you remove that.

@bunnycou
Copy link
Author

bunnycou commented Feb 3, 2025

Oh I thought it wanted the project path from the csproj not the github url. And I don't use github outside of solo dev much so sorry for not doing PRs properly lol.

auto-merge was automatically disabled February 3, 2025 22:50

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Feb 3, 2025

All builds OK!

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

Name Commit Status
✔️ MSQTracker [testing-live] 798b591 v0.0.0.1 - Repo (New plugin)
11 Needs (⚠️ 2 UNREVIEWED)
Type Name Version Reviewed by
NuGet HtmlAgilityPack 1.11.72 ⚠️ Upd. from 1.11.54
NuGet HtmlAgilityPack.CssSelectors.NetCore 1.2.1 ⚠️ NEW
NuGet Microsoft.Build.Tasks.Git 1.1.1 goaaats
8 hidden needs (known safe NuGet packages).
Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed build failed This plugin failed to build. labels Feb 3, 2025
@philpax
Copy link
Contributor

philpax commented Feb 3, 2025

This plugin is now in the plugin review queue; we hope to get back to you soon!

@philpax philpax added pending-code-review This plugin still needs code review. pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. pending-testing This plugin still needs to be tested. completed-rules-compliance This plugin is compliant with all rules. and removed pending-rules-compliance This plugin still needs to be checked for rules compliance by the majority of the PAC. labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@goaaats goaaats

Labels
completed-rules-compliance This plugin is compliant with all rules. new plugin This is a new plugin. pending-code-review This plugin still needs code review. pending-testing This plugin still needs to be tested. size-large Diff for this PR is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bunnycou @bleatbot @philpax @goaaats